All `tests` (golang-<version>) jobs are failing now
For example, job #4563144016 failed for 3eaa4ebe:
--snip--
$ make verify test
gofmt -s -l client/client_test.go client/gitlabnet.go client/httpclient.go client/httpclient_test.go client/httpsclient_test.go client/testserver/gitalyserver.go client/testserver/testserver.go client/transport.go cmd/check/command/command.go cmd/check/command/command_test.go cmd/check/main.go cmd/gitlab-shell-authorized-keys-check/command/command.go cmd/gitlab-shell-authorized-keys-check/command/command_test.go cmd/gitlab-shell-authorized-keys-check/main.go cmd/gitlab-shell-authorized-principals-check/command/command.go cmd/gitlab-shell-authorized-principals-check/command/command_test.go cmd/gitlab-shell-authorized-principals-check/main.go cmd/gitlab-shell/command/command.go cmd/gitlab-shell/command/command_test.go cmd/gitlab-shell/main.go cmd/gitlab-sshd/acceptance_test.go cmd/gitlab-sshd/main.go internal/command/authorizedkeys/authorized_keys.go internal/command/authorizedkeys/authorized_keys_test.go internal/command/authorizedprincipals/authorized_principals.go internal/command/authorizedprincipals/authorized_principals_test.go internal/command/command.go internal/command/command_test.go internal/command/commandargs/authorized_keys.go internal/command/commandargs/authorized_principals.go internal/command/commandargs/command_args.go internal/command/commandargs/shell.go internal/command/discover/discover.go internal/command/discover/discover_test.go internal/command/githttp/push.go internal/command/githttp/push_test.go internal/command/healthcheck/healthcheck.go internal/command/healthcheck/healthcheck_test.go internal/command/lfsauthenticate/lfsauthenticate.go internal/command/lfsauthenticate/lfsauthenticate_test.go internal/command/personalaccesstoken/personalaccesstoken.go internal/command/personalaccesstoken/personalaccesstoken_test.go internal/command/readwriter/readwriter.go internal/command/receivepack/gitalycall.go internal/command/receivepack/gitalycall_test.go internal/command/receivepack/receivepack.go internal/command/receivepack/receivepack_test.go internal/command/shared/accessverifier/accessverifier.go internal/command/shared/accessverifier/accessverifier_test.go internal/command/shared/customaction/customaction.go internal/command/shared/customaction/customaction_test.go internal/command/shared/disallowedcommand/disallowedcommand.go internal/command/twofactorrecover/twofactorrecover.go internal/command/twofactorrecover/twofactorrecover_test.go internal/command/twofactorverify/twofactorverify.go internal/command/twofactorverify/twofactorverify_test.go internal/command/uploadarchive/gitalycall.go internal/command/uploadarchive/gitalycall_test.go internal/command/uploadarchive/uploadarchive.go internal/command/uploadarchive/uploadarchive_test.go internal/command/uploadpack/gitalycall.go internal/command/uploadpack/gitalycall_test.go internal/command/uploadpack/uploadpack.go internal/command/uploadpack/uploadpack_test.go internal/config/config.go internal/config/config_test.go internal/console/console.go internal/console/console_test.go internal/executable/executable.go internal/executable/executable_test.go internal/gitaly/gitaly.go internal/gitaly/gitaly_test.go internal/gitlabnet/accessverifier/client.go internal/gitlabnet/accessverifier/client_test.go internal/gitlabnet/authorizedkeys/client.go internal/gitlabnet/authorizedkeys/client_test.go internal/gitlabnet/client.go internal/gitlabnet/discover/client.go internal/gitlabnet/discover/client_test.go internal/gitlabnet/git/client.go internal/gitlabnet/git/client_test.go internal/gitlabnet/healthcheck/client.go internal/gitlabnet/healthcheck/client_test.go internal/gitlabnet/lfsauthenticate/client.go internal/gitlabnet/lfsauthenticate/client_test.go internal/gitlabnet/personalaccesstoken/client.go internal/gitlabnet/personalaccesstoken/client_test.go internal/gitlabnet/twofactorrecover/client.go internal/gitlabnet/twofactorrecover/client_test.go internal/gitlabnet/twofactorverify/client.go internal/gitlabnet/twofactorverify/client_test.go internal/handler/exec.go internal/handler/exec_test.go internal/keyline/key_line.go internal/keyline/key_line_test.go internal/logger/logger.go internal/logger/logger_test.go internal/metrics/metrics.go internal/pktline/pktline.go internal/pktline/pktline_test.go internal/sshd/connection.go internal/sshd/connection_test.go internal/sshd/gssapi.go internal/sshd/gssapi_test.go internal/sshd/gssapi_unsupported.go internal/sshd/server_config.go internal/sshd/server_config_test.go internal/sshd/session.go internal/sshd/session_test.go internal/sshd/sshd.go internal/sshd/sshd_test.go internal/sshenv/sshenv.go internal/sshenv/sshenv_test.go internal/testhelper/requesthandlers/requesthandlers.go internal/testhelper/testhelper.go | awk '{ print } END { if (NR > 0) { print "Please run make fmt"; exit 1 } }'
bundle exec rspec --color --format d spec
bundler: command not found: rspec
Install missing gem executables with `bundle install`
make: *** [Makefile:53: test_ruby] Error 127
--snip--
Edited by Ash McKenzie