Replace os.MkdirTemp usages by t.TempDir
We use os.MkdirTemp
to create gitaly and unix test servers:
client/testserver/gitalyserver.go
87: tempDir, _ := os.MkdirTemp("", "gitlab-shell-test-api")
client/testserver/testserver.go
21: tempDir, _ = os.MkdirTemp("", "gitlab-shell-test-api")
internal/logger/logger_test.go
64: tmpPath, err := os.MkdirTemp(os.TempDir(), "logtest-")
internal/testhelper/testhelper.go
15: TestRoot, _ = os.MkdirTemp("", "test-gitlab-shell")
cmd/gitlab-sshd/acceptance_test.go
262: dir, err := os.MkdirTemp("", "gitlab-sshd-acceptance-test-")
However, testing
package provides https://pkg.go.dev/testing#T.TempDir, which provides the same functionality but also includes the cleaning up.
Let's refactor the code and replace os.MkdirTemp
usages with t.TempDir
as we did in gitlab@cad99a85.
Related: internal/command/uploadarchive/uploadarchive_te... (#671 - closed)
Edited by Ash McKenzie