Skip to content

Lint issue in client/ package

client/client_test.go:24:2: var-naming: var defaultHttpOpts should be defaultHTTPOpts (revive)
client/client_test.go:114:3: expected-actual: need to reverse actual and expected values (testifylint)
client/client_test.go:136:30: response body must be closed (bodyclose)
client/client_test.go:142:31: response body must be closed (bodyclose)
client/client_test.go:150:30: response body must be closed (bodyclose)
client/client_test.go:156:31: response body must be closed (bodyclose)
client/client_test.go:164:30: response body must be closed (bodyclose)
client/client_test.go:170:31: response body must be closed (bodyclose)
client/client_test.go:182:72: unused-parameter: parameter 'token' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:243:5: go-require: do not use require in http handlers (testifylint)
client/client_test.go:251:5: go-require: do not use require in http handlers (testifylint)
client/client_test.go:256:5: go-require: do not use require in http handlers (testifylint)
client/client_test.go:275:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:286:18: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:304:73: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:316:21: response body must be closed (bodyclose)
client/httpclient.go:209:22: G115: integer overflow conversion uint64 -> int64 (gosec)
client/httpclient_test.go:37:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:45:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:85:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:103:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:109:5: go-require: do not use require in http handlers (testifylint)
client/httpsclient_test.go:62:4: expected-actual: need to reverse actual and expected values (testifylint)
client/httpsclient_test.go:105:24: response body must be closed (bodyclose)
client/httpsclient_test.go:108:5: expected-actual: need to reverse actual and expected values (testifylint)
client/httpsclient_test.go:119:5: go-require: do not use require in http handlers (testifylint)
client/testserver/gitalyserver.go:1:1: package-comments: should have a package comment (revive)
client/testserver/gitalyserver.go:21:6: exported: exported type TestGitalyServer should have comment or be unexported (revive)
client/testserver/gitalyserver.go:26:1: exported: exported method TestGitalyServer.SSHReceivePack should have comment or be unexported (revive)
client/testserver/gitalyserver.go:38:1: exported: exported method TestGitalyServer.SSHUploadPack should have comment or be unexported (revive)
client/testserver/gitalyserver.go:50:1: exported: exported method TestGitalyServer.SSHUploadPackWithSidechannel should have comment or be unexported (revive)
client/testserver/gitalyserver.go:55:18: Error return value of `conn.Close` is not checked (errcheck)
client/testserver/gitalyserver.go:70:1: exported: exported method TestGitalyServer.SSHUploadArchive should have comment or be unexported (revive)
client/testserver/gitalyserver.go:82:1: exported: exported function StartGitalyServer should have comment or be unexported (revive)
client/testserver/gitalyserver.go:131:3: go-require: require must only be used in the goroutine running the test function (testifylint)
client/testserver/testserver.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
client/testserver/testserver.go:20:6: exported: exported type TestRequestHandler should have comment or be unexported (revive)
client/testserver/testserver.go:46:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
client/testserver/testserver.go:52:17: Error return value of `server.Serve` is not checked (errcheck)
client/testserver/testserver.go:117:18: G304: Potential file inclusion via variable (gosec)
client/transport.go:58:1: exported: exported function DefaultTransport should have comment or be unexported (revive)
client/transport.go:62:1: exported: exported function NewTransport should have comment or be unexported (revive)