New product icon > thumbtack-solid
Description
Concept
Adding a solid state for the thumbstack
icon to accommodate the feature to add pinning in groups an projects in gitlab#378547 (closed)
thumbtack |
|
---|---|
Figma file
❖ View working file in Figma →
Checklists
Make sure the following are completed before closing the issue:
Assignee tasks:
See tasks:
-
Create a branch of the GitLab Product Icons when updating or creating an icon. - Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example,
#860-new-icon-lvanc
.
- Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example,
-
Update the link to the working file under the Figma link section above. -
If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: - For all other changes, move your file to the Misc archive project.
- If you’re a community contributor, please consider transferring ownership of your draft file to the maintainer so they can move it to our archive, along with its version history and comments.
-
When applicable, follow our iconography guidelines. -
Ask a Foundations designer to review your design. - Ensure the designer that will be reviewing your file has edit permissions in Figma.
Reviewer tasks:
See tasks:
-
Review the icon in the author’s branch. Add design-specific comments in Figma to maintain context. Add general comments to this issue, including your approval status. -
Once review is approved, assign to a Figma maintainer for final review.
Maintainer tasks:
See tasks:
-
Merge the branch to the GitLab Product Icons file, convert the icon to a component, add keywords and usage notes (optional) in the description, and view it in the Assets panel to ensure it aligns with what’s outlined in the document and asset library structure documentation. -
Publish the library changes along with a clear message about the update.
Library addition tasks:
Once the Reviewer or Maintainer has approved your icon design, consider the following tasks to add the icon the gitlab-svgs
library.
See tasks:
-
Create a new merge request (MR) from this issue. -
Checkout the new branch locally. -
Export the icon component from the Pajamas UI Kit (in Figma) to the /sprite_icons folder in your local instance of the repo. The file name should be lowercase, and use hyphens as a separator between terms. -
Open the SVG you just exported in your code editor and remove fill="none"
from the<svg>
element. -
In a terminal window, run yarn run dev
to preview the SVG library locally. Find the new icon and test it out by changing settings in the Icon configuration panel of the site. The icon should change color and size with no issues. -
After you’ve committed the changes and the pipeline passes, double-check your icon in the review app and test that it matches your expectations. -
Assign the MR to be reviewed and merged by a maintainer, and proceed with any changes. -
Add a read only (FYI) agenda item to the next UX weekly call to inform everyone of the new icon, linking to this issue.
If you run into any problems, ensure that all other steps in the project README have been followed.
-
🎉 Congrats, you made it! You can now close this issue.
Links / references
Edited by Austin Regnery