Prefer native type check methods over lodash's
The following discussion from !3305 (merged) should be addressed:
-
@markrian started a discussion: thought: We should probably replace all uses of this with
Array.isArray
, but that's outside the scope of this MR.
Implementation plan
-
Replace all usages of lodash's isArray
with the nativeArray.isArray
method. -
Replace all usages of lodash's isFinite
with the nativeNumber.isFinite
method. -
We may want to look into installing eslint-plugin-you-dont-need-lodash-underscore to ensure we're always favoring native methods. Should probably be done in https://gitlab.com/gitlab-org/frontend/eslint-plugin.
Edited by Savas Vedova