Proposal: Merge GlSkeletonLoading functionality into GlSkeletonLoader and deprecate GlSkeletonLoading
GlSkeletonLoading
and GlSkeletonLoader
have very similar functionality that could be combined to reduce confusion and make GitLab UI more maintainable.
Proposal
GlSkeletonLoader
Changes to - Add
DEFAULT_LINE_WIDTH_PERCENTAGES
as a constant from https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/skeleton_loading/skeleton_loading.scss#L4 - Add
lines
prop that defaults to3
and is used to render the defaultslot
value. - Add
equal-width-lines
prop that defaults tofalse
. The default lines will be the same width if this istrue
. - Add default value to
slot
. This default value would be a SVG rectangle that is rendered based on thelines
prop,equal-width-lines
prop andDEFAULT_LINE_WIDTH_PERCENTAGES
constant.
GlSkeletonLoading
Changes to - Add deprecated message. "This component is deprecated, please use
GlSkeletonLoader
."
Edited by Peter Hegman