Skip to content

MR Review: Show changed file diff (API-provided)

Problem to solve

When reviewing MRs, users need to see changed files. This is going to be the first iteration of showing users the changes made in the file.

Proposal

Extension<span data-escaped-char>_</span>Development<span data-escaped-char>_</span>Host<span data-escaped-char>_</span>-<span data-escaped-char>_</span>terraform<span data-escaped-char>_</span>list<span data-escaped-char>_</span>vue<span data-escaped-char>_</span><span data-escaped-char>_</span>MR<span data-escaped-char>_</span><span data-escaped-char>_</span><span data-escaped-char>_</span><span data-escaped-char>_</span>gitlab<span data-escaped-char>_</span>and<span data-escaped-char>_</span>Add<span data-escaped-char>_</span><span data-escaped-char>_</span>Ability<span data-escaped-char>_</span>to<span data-escaped-char>_</span>chec<span data-escaped-char>_</span><span data-escaped-char>_</span><span data-escaped-char>_</span><span data-escaped-char>_</span><span data-escaped-char>_</span><span data-escaped-char>_</span>gitlab-vscode-extension<span data-escaped-char>_</span>and<span data-escaped-char>_</span>zsh

Once the user clicks on a changed file (see #263 (closed)), VS Code will open a file diff showing the change. VS Code will get file content from the GitLab instance API.

Further details

Showing the diff is explained in the MR Review POC. When we are done, we'll have a chain of content providers as shown in:

graph LR
A[VS Code] -- "gl-review: URI" --> B[LocalGitContentProvider]
B --> C[RemoteApiContentProvider]

This issue is going to implement the remote content provider. We'll start with the remote provider in the first iteration because the remote provider will always have the content and the local git provider is optimisation that we'll implement next.

Showing diff for images and other binaries is out of scope.

We need to have a look into how to show diffs of extra large text files like package-lock.json.

Links / references