Skip to content

MR Review: Show change type for each changed file

Problem to solve

This is a follow-up to #263 (closed). Currently, we are indicating the type of git change by prepending [added], [deleted], [renamed] to the item description.

Extension_Development_Host_-_Welcome___gitlab-vscode-extension-TEST

But once the FileDecorations are generally available in the next VS Code release, we should use them instead:

mr_item_ts___gitlab-vscode-extension

Proposal

Implement the FileDecorationProvider once at least 90% of the users are on the latest version (^1.52.0).

Further details

I looked into the logs today (2020-12-02) and I saw that roughly 90% of extension requests on gitlab.com are made by the latest VS Code version. Today is 21 days since the latest VS Code version has been released.

These numbers can be checked in the logs https://log.gprd.gitlab.net/ (only GitLab team members).

  • index: pubsub-workhorse-inf-gprd-*
  • query: json.user_agent : "vs-code-gitlab-workflow/3.6.2 VSCode/" AND NOT json.user_agent : "vs-code-gitlab-workflow/3.6.2 VSCode/1.51.1" (replace versions by the latest)

Links / references