Advanced search is broken + minor errors in issuable search
Summary
The extension has a rudimentary search feature (it shows you input box and then it opens the web search results for you).
There are 3 commands:
GitLab: Search Project Issues (Supports Filters)
GitLab: Search Project Merge Requests (Supports Filters)
GitLab: Project Advanced Search (Issues, MR's, Commits, Comments...)
The advanced project search doesn't work. The remaining searches are sometimes throwing errors (no user-facing defects though).
Steps to reproduce
- Open GitLab project in VS Code
- run the
GitLab: Project Advanced Search (Issues, MR's, Commits, Comments...)
- type in any query that would normally return results
- see that the search results are empty
What is the current bug behavior?
The extension creates URL with project_id=undefined
in it and the search results are empty.
What is the expected correct behavior?
The extension creates correct URL and there are search results.
Relevant logs and/or screenshots
Possible fixes
We use project.id
in search_input.js
, we should use project.restId
. Best solution is to migrate this small file to TS, which would discover such an issue.