Clarify detected license results in MR
Problem:
A | B |
---|---|
The MR widget displays new licenses introduced in the Merge Request. However, it's unclear what the results mean as they are indicted with non-descript icons. | The license classification "Approve license" is confusing, as it may relate to existing approvals feature and possible license approval group for consideration. The below image is seen when opening a license that is blacklisted; marked with an X icon seen in image A. |
Solution:
Use explicit text to categorize the findings, what the categorization means, update icon for uncategorized from •
to -
. UI review:
- Section text includes:
and policy violation
(if 1 or more denied licenses are detected) - Header (
14px/600
), subtext (14px/400
). displayed in the following order (if coordinated license detected):-
Denied
w/ subtext:Out-of-compliance with this project's policies and should be removed
-
Uncatecorized
w/ subtext:No policy matches this license
-
Allowed
w/ subtext:Acceptable for use in this project
-
earlier iteration
| Icon with tooltip | Text Headers | | ------ | ------ | | | | | Replace the `•` icon, to `-` with tooltip (tooltip to explain classifications) | The non-classified or unknown licenses labeled "uncategorized". Use classification text-names to organize license detected in MR (don't rely on icons). Organized order: denied, uncategorized, allowed |License classifications
Based on #12937 (closed):
- Uncategorized, admin has not selected classification
- Allowed, admin has classified license as acceptable
- Allow, used in the call-to-action seen in the MR (admin view) to classify license as Allowed
- Denied, project participant views this classification when admin classified license as not allowed
- Deny, used in the call-to-action seen in the MR (admin view) to classify license as unacceptable
Edited by 🤖 GitLab Bot 🤖