Use `all_pipelines` instead of `ci_pipelines` in Security Dashboard code
As Douwe points out in the below thread, we should probably be using Project#all_pipelines
instead of Project#ci_pipelines
. We are using it in ee/lib/api/vulnerabilities.rb#vulnerability_occurrences_by
and ee/app/models/ee/project.rb#latest_pipeline_with_security_reports
.
There may be other places in the Security Dashboard code that also need to be changed, but we should verify the change makes sense before making it.
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14376#note_188354529
- Why are we using
Project#ci_pipelines
here, butProject#all_pipelines
inProjects::PipelinesController#pipeline
? Should we useall_pipelines
in both places, or isci_pipeline
more appropriate here?