Skip to content

Mirror URL encoding error

Summary

When trying to mirror a repository, if your password contains characters that should be URL encoded a 500 error appears.

Steps to reproduce

  1. Create new repo
  2. Navigate to Mirror Repositories
  3. Enter a Git repository URL with special chars.
  4. Click save changes.

What is the current bug behavior?

Gtlab 500 error

What is the expected correct behavior?

Either a more informative error, or correct the encoding.

Relevant logs and/or screenshots

Bug2

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

GitLab Enterprise Edition 8.17.0-rc1-ee 874850a

Possible fixes

Only the username and password element of the URL need to be encoded. Encoding these specific elements may be tricky without splitting them out in the UI. Splitting them out into separate fields would have the benefit of allowing encryption of the password server side, as currently it has to be plain text.