Large diffs show up as `Showing 1 changed file with 0 additions and 0 deletions`
Summary
While reproducing https://gitlab.com/gitlab-org/gitlab-ce/issues/19323, I noticed that large diffs are shown as 0 additions and 0 deletions
, instead of showing the number of lines actually changed.
This can be seen in:
- https://gitlab.com/jamietanna/gitlab-test-repo/commit/809e4ab7f033f424032d90428f6771080780bc5e
- https://gitlab.com/jamietanna/gitlab-test-repo/commit/3fe2e73c9af648f3faabff0a9e7178a638bf96d9
If multiple files are changed in the same commit, only the smaller file changes are recorded. I.e. https://gitlab.com/jamietanna/gitlab-test-repo/commit/6986f929234e2be5655b5b676b1890e42c7df055 makes a small edit in one file, and a large change in another, yet shows up as Showing 2 changed files with 2 additions and 0 deletions
.
Steps to reproduce
- Create a commit with a large number of lines changed, i.e. 3000.
- This can be done via
cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n3000 > large-file
- This can be done via
- Push to Gitlab
- View commit in Gitlab web UI
What is the current bug behavior?
Line addition and deletion counts do not include large changes when they are added to a commit.
What is the expected correct behavior?
Line addition and deletion counts should include any files that are too large to display in the web UI.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
GitLab Enterprise Edition 8.17.2-ee 474978d
Results of GitLab application Check
N/A