Skip to content

Removing :single_mr_diff_view and :diffs_batch_load feature flags

What

Remove the :single_mr_diff_view feature flag ... Remove the :diffs_batch_load feature flag ...

Owners

  • Team: Create: Source Code Frontend
  • Most appropriate slack channel to reach out to: #g_create_source-code
  • Best individual to reach out to: @thomasrandolph (or @andr3)

Expectations

### What are we expecting to happen?

Faster MR load times since we're not loading both inline and parallel data anymore (with ff on).

What might happen if this goes wrong?

Any MR functionality broken—especially after toggling between inline or parallel—, namely:

  • comments
  • MR Reviews
  • Suggestions

What can we monitor to detect problems with this?

At the stage of setting this to default true, is basically monitoring bugs being created, especially customer ones since it'll be enabled on gitlab.com before it:

https://gitlab.com/gitlab-org/gitlab/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=merge%20requests&label_name[]=bug

Beta groups/projects

If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.

  • gitlab-org/gitlab project
  • gitlab-org/gitlab-com groups

Roll Out Steps

  • Enable on staging
  • Test on staging
  • Ensure that documentation has been updated
  • Enable on GitLab.com for individual groups/projects listed above and verify behaviour
  • Coordinate a time to enable the flag with #production and #g_delivery on slack.
  • Announce on the issue an estimated time this will be enabled on GitLab.com
  • Enable on GitLab.com by running chatops command in #production
  • Cross post chatops slack command to #support_gitlab-com and in your team channel
  • Announce on the issue that the flag has been enabled
  • After Feature Flag has run for at least 24hrs in production with no reported problems, update the feature flag to default to true and add changelog entry
  • On the following Release, remove feature flag code
  • After the flag removal is deployed, clean up the feature flag by running chatops command in #production channel
Edited by André Luís