Status API returns 400 after successful creation of self monitorng project
Summary
(Summarize the bug encountered concisely)
When enabling the self-monitoring project, the status API returns 400 when the self-monitoring project has been successfully created instead of 200.
Steps to reproduce
(How one can reproduce the issue - this is very important)
- Enable feature flag
self_monitoring_project
. - Go to the Admin area -> Settings -> Metrics and profiling -> Expand Self monitoring
- Keep your browser console open to the "Network" tab so that you can observe XHR requests being made.
- Click the toggle button to trigger creation of the self-monitoring project.
- Once the project is created, the status API should return 200 but returns 400.
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
(What actually happens)
What is the expected correct behavior?
(What you should see instead)
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
This appears to be because of Gitlab::CurrentSettings
caching. The ID of the self-monitoring project is stored in application_settings
, so once the creation job has completed, the controller tries to get the ID of the project from Gitlab::CurrentSettings
, but since the application_settings
was modified in a Sidekiq worker, the cache in the main process (where the controller is running) still has the old value.
We can expire Gitlab::CurrentSettings
after the job completes but before trying to retrieve the ID of the self-monitoring project.