Merge request user interface encourages accidentally closing the request
The merge request interface has 2 buttons below the comment box, Comment
and Comment & Close merge request
(or Close merge request
). Their proximity makes it too easy to close requests accidentally, breeding misunderstanding and bad feelings between the developers. This is especially evil considering the other action offered by the interface (starting/closing a discussion).
To fix the above misunderstanding, please move the "close merge request" button away from text areas. E.g., make it a diagonal cross icon in the top right of the entire merge request page. Put an additional confirmation prompt on clicking the button by mistake.
In addition, when a discussion is "closed", it looks as if whoever "closed" the discussion does not want to discuss the question any more. This can bring another terrible misunderstanding. Multiply this by thousand customers with dozens merge request each, get the popularity of code review and code quality suffer.