Code review start time doesn't account for approvals
Summary
On the code review analytics only the first comment is being considered for the beginning of a review. If the MR has received a previous approval that should also be considered. The earliest timestamp of first approval or first comment should be the beginning of the review.
What is the current behavior?
Since there were no comments review time is shown as undefined.
The actual issue is not fully apparent yet in the screenshot, but it will be in our face once #197883 (closed) is in. There will be an entry for approver (possibly multiple), but yet an undefined review time.
What is the preferred behavior?
I expected to see that review time was 2 hours.
Possible fixes
It appears, the following needs to be done:
-
Review time computation should be updated here -
But since the MRs ordered in the descending of review_time, we should also update the definition of ordering on review_time here, which is used by sort_by_attribute
here. -
Then there's also computing the grouping columns here.
Edited by Dan Jensen