[async_merge_request_check_mergeability] Enable asynchronous merge request mergeability check
What
Remove the async_merge_request_check_mergeability
feature flag when we see no negative effects on performance and worker is stable. The feature flag is introduced in !21026 (merged).
Owners
- Team: Create::Source Code
- Most appropriate slack channel to reach out to:
#g_create_source_code
- Best individual to reach out to: @patrickbajao
Expectations
### What are we expecting to happen?
Merge requests will still be marked as mergeable if there are no conflicts and no pending approval.
What might happen if this goes wrong?
Merge requests don't get marked as mergeable even if there are no conflicts and no pending approval.
What can we monitor to detect problems with this?
- https://dashboards.gitlab.net/d/sidekiq-queue-detail/sidekiq-queue-detail?orgId=1&var-PROMETHEUS_DS=Global&var-environment=gprd&var-stage=main&var-queue=merge_request_mergeability_check
- https://dashboards.gitlab.net/d/rPsQXrImk/rails-controller?orgId=1&refresh=1m&var-env=gprd&var-type=web&var-stage=main&var-controller=Projects::MergeRequestsController&var-action=show&var-action=show.json
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project
Roll Out Steps
-
Enable on staging -
Test on staging -
Enable on dev.gitlab.org -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
-
Cross post chatops slack command to #support_gitlab-com
and in your team channel -
Announce on the issue that the flag has been enabled -
Enable feature flag by default and add changelog entry
Edited by Patrick Bajao