[VSA] Incorrectly saying "not enough data" for stages that average less than 1 second
Summary
It's possible for a Cycle Analytics stage to be completed in less than 1 second on average. When that happens Cycle Analytics says "not enough data" instead of "less than a minute". @ahegyi found this bug and determined it's because floats are returned from the database, but are converted to zero when they are cast to integers. (For example 0.8.to_i
will return 0
.)
Steps to reproduce
- Go to https://gitlab.com/-/analytics/cycle_analytics
- See the "Issue" stage says "Not enough data"
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
Cycle Analytics displays "Not enough data" for a stage when the average is less than one second.
What is the expected correct behavior?
Cycle Analytics displays "less than a minute" for a stage when the average is less than one second.
Relevant logs and/or screenshots
@ahegyi pointed out this problem in a discussion in Slack#s_manage_analytics.
Example:
Output of checks
This bug happens on GitLab.com.
Possible fixes
- Interpret
0
as "less than a minute" instead of "not enough data".