Dashboard specs should remove done() in favor of returning promises
Description
In some cases the dashboard specs (spec/frontend/monitoring/components/dashboard_spec.js
) return the promises when finished, and in some others they use done().
We should make the file consistent by only using the return method unless necessary.
Original Discussion
The following discussion from !24240 (merged) should be addressed:
-
@markrian started a discussion: (+2 comments) Since this is Jest, you can return the promise, and do away with
done
:it('calls to set time range and fetch data', () => { jest.spyOn(store, 'dispatch'); createShallowWrapper({ hasMetrics: true }, { methods: {} }); return wrapper.vm .$nextTick() .then(() => { expect(store.dispatch).toHaveBeenCalledWith( 'monitoringDashboard/setTimeRange', expect.any(Object), ); expect(store.dispatch).toHaveBeenCalledWith('monitoringDashboard/fetchData', undefined); });
Edited by Miguel Rincon