Geo - Query to retrieve Job Artifacts always use the selective sync version
Summary
While implementing selective support for the FDW queries to retrieve Job Artifacts in !11892 (merged) the queries generated by GeoNode#job_artifacts
and Geo::Fdw::GeoNode#job_artifacts
always use the selective sync version even when the selective sync is disabled due to a missing return
in the guard clause.`.
What is the current bug behavior?
Even when the selective sync is disabled we are using the CTE version of the query that degrades the performance.
What is the expected correct behavior?
When selective sync is disabled we don't need to use the CTE version of the query.
Possible fixes
Fix the guard clause with the missing return
.