Improve ReactiveCache key naming
We should improve ReactiveCache key naming, so that:
- Key names are shorter, to improve
SCAN
time - We have a consistent naming scheme
The following discussion from !24761 (merged) should be addressed:
-
@stanhu started a discussion: (+1 comment) With
redis-cli monitor
, I'm seeing really ugly keys:1582665309.364412 [0 unix:/Users/stanhu/gitlab/gdk-ee/redis/redis.socket] "set" "cache:gitlab:error_tracking_project_error_tracking_setting:1:list_issues:{\"issue_status\"=>\"unresolved\", \"limit\"=>20, \"sort\"=>\"last_seen\"}:alive" "\x04\bo: ActiveSupport::Cache::Entry\t:\x0b@valueT:\r@version0:\x10@created_atf\x161582665309.364319:\x10@expires_in0" 1582665309.364827 [0 unix:/Users/stanhu/gitlab/gdk-ee/redis/redis.socket] "set" "cache:gitlab:error_tracking_project_error_tracking_setting:1:list_issues:{\"issue_status\"=>\"unresolved\", \"limit\"=>20, \"sort\"=>\"last_seen\"}:alive" "\x04\bo: ActiveSupport::Cache::Entry\t:\x0b@valueT:\r@version0:\x10@created_atf\x161582665309.364775:\x10@expires_in0"
Can we clean this up by doing something like:
opts.map { |key, value| "#{key}:#{value}" }.join(":")
Edited by Sean Arnold