`ee/spec/controllers/ldap/omniauth_callbacks_controller_spec.rb[1:3:1]` only pass after a retry
Run bin/rspec 'ee/spec/controllers/ldap/omniauth_callbacks_controller_spec.rb[1:3:1]'
locally, the test fails.
Run RETRIES=1 bin/rspec 'ee/spec/controllers/ldap/omniauth_callbacks_controller_spec.rb[1:3:1]'
locally, the test passes.
@jamedjo I think we stopped logging failed LDAP logging with f10c999b.
The logging was added by @jameslopez with e74c7e2a but:
- since
Ldap::OmniauthCallbacksController < OmniauthCallbacksController
andLdap::OmniauthCallbacksController
redefines#fail_login
(https://gitlab.com/gitlab-org/gitlab/-/blob/7cebe9c5217fcc9cdba24b33d3e753e146f65896/app/controllers/ldap/omniauth_callbacks_controller.rb#L30-34), - the extra behavior added by
EE::OmniauthCallbacksController
(https://gitlab.com/gitlab-org/gitlab/-/blob/7cebe9c5217fcc9cdba24b33d3e753e146f65896/ee/app/controllers/ee/omniauth_callbacks_controller.rb#L20-24) toOmniauthCallbacksController
(https://gitlab.com/gitlab-org/gitlab/-/blob/7cebe9c5217fcc9cdba24b33d3e753e146f65896/app/controllers/omniauth_callbacks_controller.rb#L274) is not triggered.
I will submit a MR to fix that, and make the test pass on first try.