Review app deployment is not pulling latest image
Problem
It looks like review app deployment might not pull the latest container image created by the most recent CNG build.
In pipeline https://gitlab.com/gitlab-org/gitlab/pipelines/130217195:
- CNG-Mirror pipeline: https://gitlab.com/gitlab-org/build/CNG-mirror/pipelines/130220464
- gitlab-webservice-ee job: https://gitlab.com/gitlab-org/build/CNG-mirror/-/jobs/487689891
- this job pushed image
sha256:34f501f26067720744513a50cca90543b7765a682146d9da1d11c951c4d70ca7
to the tag
- this job pushed image
- gitlab-webservice-ee job: https://gitlab.com/gitlab-org/build/CNG-mirror/-/jobs/487689891
- review-deploy job https://gitlab.com/gitlab-org/gitlab/-/jobs/487714638
- this deployment has
global.imagePullPolicy: ifNotPresent
set (see log line 3662) - the pods were not replaced in this deployment - they are 91m old (see log line 10953)
- inspecting the pod
review-caalberts-4xwx45-unicorn-969d64479-khc9k
, the image id is not the latest image id pushed ingitlab-webservice-ee
job above
- this deployment has
Containers:
unicorn:
Container ID: containerd://e595dd04fddf800d72adfa81c128c17fa57288b83752404a8d4084fab5978e5f
Image: registry.gitlab.com/gitlab-org/build/cng-mirror/gitlab-webservice-ee:caalberts-test-review-apps
Image ID: registry.gitlab.com/gitlab-org/build/cng-mirror/gitlab-webservice-ee@sha256:3caeb387480cc51d6fc9fd7825c23fd4daa98571c7607f82daefeffb7778a628
Solution
We should use deployment strategy Recreate
to immediately recreate pods
Edited by Albert Salim