Improve Telemetry warning message in danger bot
Problem
Warning we have now in Danger bot for Telemetry review doesn't say clear who should take action on it What we have now
This merge request adds or changes files for which a
review from the Data team and Telemetry team is recommended.
@gitlab-org/growth/telemetry group is mentioned in order to notify team members.
Proposal
Reading the The responsibility of the merge request author
To reach the required level of confidence in their solution, an author is expected to involve other people in the investigation and implementation processes as appropriate.
They are encouraged to reach out to domain experts to discuss different solutions or get an implementation reviewed, to product managers and UX designers to clear up confusion or verify that the end result matches what they had in mind, to database specialists to get input on the data model or specific queries, or to any other developer to get an in-depth review of the solution.
If an author is unsure if a merge request needs a domain expert’s opinion, that’s usually a pretty good sign that it does, since without it the required level of confidence in their solution will not have been reached.
I believe we fall under this with the optional reviews with Telemetry reviews and adjusting the warning message will help.
Adjust the message to:
This MR has change for which a review from the Data team and Telemetry team is recommended.
Please reach out to @gitlab-org/growth/telemetry/engineer. group for a review.