Refactor `user_popover.vue` loading logic

Summary

Currently we have 3 computed properties for checking various loading states:

But they could be combined into one computed property as the single source of truth is user.loaded

Also there is a loaded prop that is no longer being used and should be removed.

See threads here for more context:

Replace these computed properties:

with

userIsLoading() {
  return !this.user.loaded
}

And use userIsLoading in the template to either show the skeleton or the data.

User popover

Edited Jul 02, 2020 by Peter Hegman