Rename Vulnerabilities::Occurrence to Vulnerabilities::Finding
Summary
Rename Vulnerabilities::OccurrencePipeline to Vulnerabilities::FindingPipeline as described in #32963 (closed). This is to make the naming terminology consistent within the feature.
Improvements
The benefits of this refactoring are more clear (and correct) codebase in regards to the terminology which has already proven itself being complex enough to avoid any additional confusion.
Risks
- Loss of functionality if a renaming is missed.
- Possible GitLab.com downtime caused by improper database tables/columns renaming.
Involved components
Classes:
- Vulnerabilities::Occurrence (
ee/app/models/vulnerabilities/occurrence.rb
) - Security::PipelineVulnerabilitiesFinder (
ee/app/finders/security/pipeline_vulnerabilities_finder.rb
) - Security::VulnerabilityFindingsFinder (
ee/app/finders/security/vulnerability_findings_finder.rb
) - Security::VulnerabilityProjectsFinder (
ee/app/finders/security/vulnerability_projects_finder.rb
) - Types::VulnerabilityReportTypeEnum (
ee/app/graphql/types/vulnerability_report_type_enum.rb
) - Types::VulnerabilitySeveritiesCountType (
ee/app/graphql/types/vulnerability_severities_count_type.rb
) - Types::VulnerabilitySeverityEnum (
ee/app/graphql/types/vulnerability_severity_enum.rb
) - Types::VulnerabilityType (
ee/app/graphql/types/vulnerability_type.rb
) - Vulnerability (
ee/app/models/vulnerability.rb
) - EE::Project (
ee/app/models/ee/project.rb
) - EE::Ci::Pipeline (
ee/app/models/ee/ci/pipeline.rb
) - Vulnerabilities::Identifier (
ee/app/models/vulnerabilities/identifier.rb
) - Vulnerabilities::OccurrenceIdentifier (
ee/app/models/vulnerabilities/occurrence_identifier.rb
) - Vulnerabilities::OccurrencePipeline (
ee/app/models/vulnerabilities/occurrence_pipeline.rb
) - Vulnerabilities::Scanner (
ee/app/models/vulnerabilities/scanner.rb
) - Security::VulnerableProjectPresenter (
ee/app/presenters/security/vulnerable_project_presenter.rb
) - VulnerabilitySummaryEntity (
ee/app/serializers/vulnerability_summary_entity.rb
) - VulnerableProjectEntity (
ee/app/serializers/vulnerability_project_entity.rb
) - Vulnerabilities::HistoryEntity (
ee/app/serializers/vulnerabilities/history_entity.rb
) - Security::DependencyListService (
ee/app/services/security/dependency_list_service.rb
) - Security::MergeReportsService (
ee/app/services/security/merge_reports_service.rb
) - Vulnerabilities::CreateService (
ee/app/services/vulnerabilities/create_service.rb
) - Gitlab::Seeder::Vulnerabilities (
ee/db/fixtures/development/20_vulnerabilities.rb
) - API::VulnerabilityFindings (
ee/lib/api/vulnerability_findings.rb
) - Gitlab::Vulnerabilities::Summary (
ee/lib/gitlab/vulnerabilities/summary.rb
)
Database Tables:
- vulnerabilities_occurrence