Images uploaded to wiki before gitlab-foss!21362 are not accessible (error 404) since update 12.10.1
Summary
Since migrating our Gitlab instance to version 12.10.1, images (or any document) uploaded to a project wiki before october 2018 are inaccessible and yield error 404. This seems to be related to gitlab-foss!21362 (merged).
Files that are inaccessible are not present in the wiki git repository, but are still present in the uploads
folder of the YYYY-MM-DD-namespace-projectname_export.tar.gz
file generated when exporting the project. Files that are located within the wiki git repository in the "uploads" folder are still correctly displayed in the wiki.
Steps to reproduce
- Have a project created with a gitlab version dating from before october 2018
- Upload an image to the project wiki
- Update the gitlab instance to 12.10.1
- Navigate to your image in the wiki. Its link will be there but clicking it leads to an error 404 page.
What is the current bug behavior?
Wiki attachments dating from before october 2018 are not displayed and give error 404. Wiki attachment dating from after october 2018 are correctly displayed and accessible.
What is the expected correct behavior?
All wiki attachments, no matter when uploaded, should be accessible.
Relevant logs and/or screenshots
From production.log
:
Parameters: {"namespace_id"=>"jadim", "project_id"=>"jadim", "secret"=>"[FILTERED]", "filename"=>"Poiseuille_tutorial_1.png"}
Processing by Projects::UploadsController#show as HTML
Parameters: {"namespace_id"=>"jadim", "project_id"=>"jadim", "secret"=>"[FILTERED]", "filename"=>"Poiseuille_tuto_4.png"}
Completed 404 Not Found in 55ms (ActiveRecord: 29.5ms | Elasticsearch: 0.0ms | Allocations: 7185)
Completed 404 Not Found in 52ms (ActiveRecord: 25.3ms | Elasticsearch: 0.0ms | Allocations: 7185)
where both png files are files uploaded before gitlab-foss!21362 (merged) was deployed and are still available in a project export.
Output of checks
Results of GitLab environment info
<gitlab> ~# gitlab-rake gitlab:env:info
System information
System:
Current User: git
Using RVM: no
Ruby Version: 2.6.5p114
Gem Version: 2.7.10
Bundler Version:1.17.3
Rake Version: 12.3.3
Redis Version: 5.0.7
Git Version: 2.26.2
Sidekiq Version:5.2.7
Go Version: unknown
GitLab information
Version: 12.10.1
Revision: e658772bd63
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 11.7
URL: https://gitlab.[FILTERED].fr/
HTTP Clone URL: https://gitlab.[FILTERED].fr/some-group/some-project.git
SSH Clone URL: git@gitlab.[FILTERED].fr:some-group/some-project.git
Using LDAP: yes
Using Omniauth: yes
Omniauth Providers:
GitLab Shell
Version: 12.2.0
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell
Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
<gitlab> ~# gitlab-rake gitlab:check SANITIZE=true
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 12.2.0 ? ... OK (12.2.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain
LDAP authentication... Anonymous. No `bind_dn` or `password` configured
LDAP users with access to your GitLab server (only showing the first 100 results)
User output sanitized. Found 100 users of 100 limit.
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
3/1 ... yes
[... some lines removed, only "yes" were here ...]
197/113 ... yes
Redis version >= 4.0.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.5)
Git version >= 2.22.0 ? ... yes (2.26.2)
Git user has default SSH configuration? ... yes
Active users: ... 195
Is authorized keys file accessible? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished