Follow-up from "Abstract `Feature Flags` usage patterns"
The following discussion from !33178 (merged) should be addressed:
-
@rymai started a discussion: (+3 comments) suggestion: I think that would be equivalent based on https://github.com/jnunemaker/flipper/blob/1b61b22fdda89a780000e56bd8c3d8ce674fb2ee/lib/flipper/feature.rb#L284, and because of
if flipper_feature
,percentage
might benil
when evaluated against<= 0
, so using&.
is probably what we want here?:percentage ||= flipper_feature&.percentage_of_time_value || 0
Remove def ab_feature_enabled?(feature, percentage: nil)