Add rubocop rules for possible dangerous metrics added in usage_ping file improve danger bot telemetry review
Problem
New metrics could break usage ping
Proposal
We are thinking to add Rubocop rules for metrics that could break usage_ping generation
Some ideas:
-
Add rule for not using one of the hardening methods for the metric added count and distinct_count on ActiveRecord models -
Use @gitlab-org/growth/telemetry/engineers
as CODEOWNERS for usage_data files -
Add count and distinct_count changes to database review -
Update database docs to link to Telemetry guide -
Add changelog and metrics definition warn in Danger
Result
End goal would be to not have dedicated telemetry reviews
Next steps (if any)
Edited by Alina Mihaila