Follow-up from "Geo - Does not sync files on Object Storage when syncing object storage is enabled, but the Object Storage is disabled for data type"
The following discussion from !33561 (merged) should be addressed:
-
@mkozono started a discussion: (+2 comments) suggestion: The original meaning of "missing on primary" was a special case where the DB records are all there, but the file itself could not be found by the primary. https://gitlab.com/gitlab-org/gitlab/blob/master/ee/lib/gitlab/geo/replication/base_transfer.rb#L221 This error cannot be known until the transfer is attempted. The secondary reacts by marking it "synced" but also "missing on primary".
It appears "missing on primary" began to be reused at some point, but I believe that is a bug. I think we need a regular error
skip_transfer_error
for this.