Fix severity and status sort order on alert list
Summary
While implementing sorting and the hover state for sorting, we realized the sort order isn't consistent across the columns. In some columns (severity and status), the upwards pointing arrow corresponds to the default sort. While in others, the down arrow corresponds to the default sort. Unfortunately, this means that users have to click on some of the columns twice to access the default sort for the column (for example, severity - they have to click on the column twice to see the most severe alerts).
Steps to reproduce
You can see these behaviors in the Tanuki project.
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
See above.
What is the expected correct behavior?
- The behaviors should be consistent across all columns
- The downwards arrow should correspond to the default sort in all instances
- Clicking on the column should immediately reveal the default sort for the column on the first click.
Info on the default sorts:
- Start time - newest alerts (default sort) = down arrow; oldest alerts = up arrow
- Severity - most critical (default sort) = down arrow; least critical = up arrow
- Status - triggered first (default sort) = down arrow; acknowledged = up arrow
- Events - most events (default sort) = down arrow; least events = up arrow
Summary of required work (from the discussion on this issue)
- The sorting order works as expected for all columns and the default sort should be the downwards arrow
- The first click on a table header should show the default sort order i.e. arrow down(severity: high -> low, start time: soonest -> oldest, end time: soonest -> oldest, events: most -> least, assignees: alphabetical order?, status: Triggered -> acknowledged -> Resolved)
- We need to fix the columns headers jumping on sort
- Sort assignee's alphabetically OR just remove the sort entirely (it's not working at all right not, we just see an error message)
- Sort arrow on hover changes position
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)