Skip to content

Webhooks with space in URL causes an error: "Something went wrong (500)"

Summary

Webhooks with space in URL causes an error: "Something went wrong (500)". Discovered when a newer version of Jenkins allows spaces in project URLs.

Steps to reproduce

  1. Create a webhook trigger with a space in the URL on Push Events
  2. Test a push event using the created webhook with a space in the URL
  3. Server will then throw an error: "Something went wrong (500)"

What is the current bug behavior?

Server throws an error: "Something went wrong (500)"

What is the expected correct behavior?

Server correctly sends webhook to URL with a space in it

Relevant logs and/or screenshots

image

Results of GitLab environment info

Expand for output related to GitLab environment info 

System information
System:         CentOS 7.3.1611
Proxy:          no
Current User:   git
Using RVM:      no
Ruby Version:   2.6.3p62
Gem Version:    2.7.9
Bundler Version:1.17.3
Rake Version:   12.3.3
Redis Version:  3.2.12
Git Version:    2.22.0
Sidekiq Version:5.2.7
Go Version:     unknown

GitLab information
Version:        12.4.1-ee
Revision:       8953eae82c8
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     PostgreSQL
DB Version:     10.9
URL:            [REDACTED]
HTTP Clone URL: [REDACTED]
SSH Clone URL:  [REDACTED]
Elasticsearch:  no
Geo:            no
Using LDAP:     yes
Using Omniauth: yes
Omniauth Providers:

GitLab Shell
Version:        10.2.0
Repository storage paths:
- default:      /var/opt/gitlab/git-data/repositories
GitLab Shell path:              /opt/gitlab/embedded/service/gitlab-shell
Git:            /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
sudo gitlab-rake gitlab:check SANITIZE=true

Checking GitLab subtasks ...


Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... OK (10.2.0)


Running /opt/gitlab/embedded/service/gitlab-shell/bin/check


Internal API available: OK


Redis available via internal API: OK


gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes


Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... Server: ldapmain


LDAP authentication... Success


LDAP users with access to your GitLab server (only showing the first 100 results)




    User output sanitized. Found 54 users of 100 limit.





Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes


Database config exists? ... yes


All migrations up? ... yes


Database contains orphaned GroupMembers? ... no


GitLab config exists? ... yes


GitLab config up to date? ... yes


Log directory writable? ... yes


Tmp directory writable? ... yes


Uploads directory exists? ... yes


Uploads directory has correct permissions? ... yes


Uploads directory tmp has correct permissions? ... yes


Init script exists? ... skipped (omnibus-gitlab has no init script)


Init script up-to-date? ... skipped (omnibus-gitlab has no init script)


Projects have namespace: ...


5/1 ... yes


9/3 ... yes


9/6 ... yes


9/7 ... yes


9/8 ... yes


5/9 ... yes


9/10 ... yes


4/11 ... yes


9/14 ... yes


5/15 ... yes


36/17 ... yes


20/19 ... yes


20/20 ... yes


9/25 ... yes


5/27 ... yes


9/28 ... yes


5/29 ... yes


6/30 ... yes


5/33 ... yes


20/35 ... yes


20/36 ... yes


5/38 ... yes


48/39 ... yes


8/43 ... yes


5/44 ... yes


57/45 ... yes


20/46 ... yes


56/48 ... yes


57/49 ... yes


57/50 ... yes


5/51 ... yes


9/52 ... yes


9/54 ... yes


5/55 ... yes


40/56 ... yes


9/57 ... yes


9/58 ... yes


5/59 ... yes


34/60 ... yes


36/61 ... yes


68/62 ... yes


68/63 ... yes


9/64 ... yes


68/65 ... yes


Redis version >= 2.8.0? ... yes


Ruby version >= 2.5.3 ? ... yes (2.6.3)


Git version >= 2.22.0 ? ... yes (2.22.0)


Git user has default SSH configuration? ... yes


Active users: ... 49


Is authorized keys file accessible? ... yes


Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited by Elias Carter