Follow-up from "Add prometheus_endpoint_path for variables"

The following discussion from !34644 (merged) should be addressed:

• @splattael started a discussion: (+2 comments)

  Looking at other DashboardProcessingErrors it seems that's the first instance which actually translates an error message.

  Usually, I prefer to see translated error messages as well 😅

  Here, however, I am not sure if these errors are meant to be presented to users, although they are. Meaning, they seem very technical and I am not sure if users could have any actionables after seeing one of these errors. They seem to be program errors caused by us 😁

  • raise DashboardProcessingError.new('Dashboard uid not found') unless uid
  • raise DashboardProcessingError.new('Datasource name not found') unless name
  • raise DashboardProcessingError.new('Grafana response contains invalid json')
  • raise DashboardProcessingError.new("Parsing error for param :embed_json. #{message}")
  • raise Errors::DashboardProcessingError.new(message)
  • raise Errors::DashboardProcessingError.new('Cluster is required for Stages::ClusterEndpointInserter') unless params[:cluster]
  • raise Errors::DashboardProcessingError.new('Cluster type must be specificed for Stages::ClusterEndpointInserter') unless params[:cluster_type]
  • raise Errors::DashboardProcessingError.new('Environment is required for Stages::MetricEndpointInserter') unless params[:environment]

              raise Errors::DashboardProcessingError.new('Environment is required for Stages::VariableEndpointInserter') unless params[:environment]

  @syasonik Should we translate the error messages above? 🤔

• @syasonik answered:

  Yeah, translations are probably the right choice.

  they seem very technical and I am not sure if users could have any actionables after seeing one of these errors.

  Looking at the list you put together, they're actually somewhat 50/50 on that. For example, those grafana-related errors are definitely meant to be addressed by the user, as there's nothing we can do to solve those problems for them.

  You're right some of the others are meant to be caught by us, though. These messages could probably use a cleanup round.