Follow-up from "Replace double angle icons with chevron"

The following discussion from !34736 (merged) should be addressed:

• @jeldergl started a discussion: (+3 comments)

I think there are a few occurrences of fa-angle-double-left and fa-angle-double-right which I am guessing is using FontAwesome icons and not GitLab SVG ones. Not saying we need to fix it here, just that it will be a good follow-up of this MR.

Correct! I don’t want to change those yet because there’s JS and templates that need to be rewritten to accommodate and that was more scope than necessary here.

The sidebar is a big offender. For example, the JS looks for an <i> element with the .fa-angle-double-left class for the script to work. It then toggles the class, which switches the angles. With SVG we’ll need to show/hide each SVG. And I suggest making the JS more universal so that any element could potentially trigger the action.

See https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/main.js#L297 and https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/right_sidebar.js#L43.