Deprecate/Remove `trace` parameter from `PUT /api/jobs/:id`
Description
In the past, GitLab-Runner was sending a job trace in two scenarios:
- During a job is running (via
PATCH /api/jobs/:id/trace
) - When a job finished (via
PUT /api/jobs/:id
)
IIRC, we recently updated GitLab-Runner to stop sending trace
parameter in the second scenario. So it should be safe to drop trace
parameter from PUT /api/jobs/:id
endpoint in GitLab-Rails.
This ensures that a problem like #24176 (closed) does not matter, that when the job.trace.set(params[:trace])
runs in the new live trace architecture, puma (api-nodes) tries to manipulate chunks in object storage (which has already been moved from redis) through ChunkedIO
. This is considerably slow process.
Proposal
Drop trace
parameter from PUT /api/jobs/:id
endpoint in GitLab-Rails.
Edited by Marius Bobin