Remove scanned_resources_count from Security::Scan
Summary
When a security job completes, the artifact is parsed and the number of scanned_resources
is saved to Security::Scan
as scanned_resources_count
. This number is then used in the security merge request widget, it is shared with the frontend using the /merge_request/dast_report
endpoint.
The security report merge request widget will switch to using the GraphQL securityReportSummary
endpoint which counts the scanned resources directly from the artifact. #229522 (closed)
Once #229522 (closed) is complete, scanned_resources_count
on Security::Scan
will no longer be used. This issue is to remove Security::Scan.scanned_resources_count
from the database and all it's associated code to generate and to serve.
Implementation Plan
-
%13.5 Ignore scanned_resources_count
onSecurity::Scan
Step 1 !44695 (merged) -
%13.6 Remove the column from the DB Step 2 !46108 (merged) -
%13.7 Remove the ignore rule Step 3 !48723 (merged)
Involved components
- https://gitlab.com/gitlab-org/gitlab/-/blob/42f861cccbf5b9e6f41c478f8b74283d1f3a43b2/db/structure.sql#L15048
- https://gitlab.com/gitlab-org/gitlab/-/blob/42f861cccbf5b9e6f41c478f8b74283d1f3a43b2/ee/app/serializers/vulnerabilities/scan_entity.rb#L6
- https://gitlab.com/gitlab-org/gitlab/-/blob/42f861cccbf5b9e6f41c478f8b74283d1f3a43b2/ee/lib/gitlab/ci/parsers/security/scanned_resources.rb#L7
- https://gitlab.com/gitlab-org/gitlab/-/blob/42f861cccbf5b9e6f41c478f8b74283d1f3a43b2/ee/app/services/security/store_scans_service.rb#L18
and any associated tests.
Optional: Intended side effects
Optional: Missing test coverage
Edited by Craig Smith