Follow-up from "Add PersonalAccessToken::RevokeService"
The following discussion from !38501 (merged) should be addressed:
-
@brytannia started a discussion: (+1 comment) I'm sorry to comment on what is broader than a scope of this MR, but I have trouble understanding what's tested in this spec. I see that table syntax is used to validate 3 cases: when a user is the owner of the token; when user is trying to revoke other user's token, when admin trying to revoke other user's token. I'd suggest to split it into contexts. Tests will be more verbose but much easier to understand. Specs are a good source of code documentation. What do you think about it?
Edited by Max Woolf