[Feature flag] Remove `security_on_demand_scans_site_profiles_feature_flag`
The :security_on_demand_scans_site_profiles_feature_flag
feature flag was introduced to let us confirm that the work done in #222755 (closed) works properly, before making it available via the main :security_on_demand_scans_feature_flag
feature flag which is still in place.
Now that we have tested the feature and confirmed that it works as expected, we can remove the feature flag.
Implementation plan
Production code
-
Stop pushing the feature flag from the controller ee/app/controllers/projects/on_demand_scans_controller.rb
. -
Remove glFeatureFlagsMixin
and conditional rendering (v-if
) fromee/app/assets/javascripts/on_demand_scans/components/on_demand_scans_app.vue
. -
Delete ee/app/assets/javascripts/on_demand_scans/components/on_demand_scans_form_old.vue
.
Specs & backstage
-
Remove ee/config/feature_flags/development/security_on_demand_scans_site_profiles_feature_flag.yml
. -
Delete ee/spec/frontend/on_demand_scans/components/on_demand_scans_form_old_spec.js
. -
Remove conditional rendering assertions from ee/spec/frontend/on_demand_scans/components/on_demand_scans_app_spec.js
.
Documentation
-
Remove mentions to security_on_demand_scans_site_profiles_feature_flag
in the docs.
Edited by Paul Gascou-Vaillancourt