Replace GlDeprecatedSkeletonLoading with GlSkeletonLoader in app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue
Instructions
-
Replace GlDeprecatedSkeletonLoading as GlSkeletonLoading
withGlSkeltonLoader
-
Replace GlSkeletonLoading
withGlSkeletonLoader
in thecomponents
property -
Replace <gl-skeleton-loading />
with<gl-skeleton-loader />
in the<template>
-
Take before/after screenshots and upload them in the Merge Request description. You can force loading by changing the v-if
value or by Throttling the Network in Chrome DevTools -
Request review from @dimitrieh
or@tauriedavis
,@jareko
, or@jeldergl
.
In most cases GlSkeletonLoader
with the default props should be a drop-in replacement for GlSkeletonLoading
. See GitLab UI docs for list of available props.
Examples
- import { GlDeprecatedSkeletonLoading as GlSkeletonLoading } from '@gitlab/ui';
+ import { GlSkeletonLoader } from '@gitlab/ui';
- components: { GlSkeletonLoading }
+ components: { GlSkeletonLoader }
- <gl-skeleton-loading :lines="2" />
+ <gl-skeleton-loader :lines="2" />