Skip to content

Visually emphasize collapsed MR diff files

The following discussion from !41393 (merged) should be addressed:

  • @pedroms started a discussion:

    @thomasrandolph @andr3 because of the significant UX change in !41393 (comment 411359008), this MR will no longer properly address the related issue: #16047 (closed)

    Since that issue is being watched by many people, I'm afraid of having this MR close it. Although that issue title is Highlight collapsed diffs in merge request diffs, it's description and comments refer to the auto-collapsing behavior, not the manual collapse. I expect that the users who have this painpoint will not be satisfied if it's closed like this.

    I suggest that we create a new issue for this MR that aligns with its outcome (visually emphasize collapsed files in merge requests), and change the title of #16047 (closed) to reflect the focus on auto-collapsed files.

(from previous issue: #16047 (closed))

Description

In merge request diffs large files are collapsed by default.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3270/diffs

diff

That's great but while reviewing and scrolling through the changes I sometimes overlook a collapsed file.

Proposal

I would suggest to highlight collapsed diffs so they can easily identified while scrolling through the changes.

image

old screenshot

diff2

Links / references

https://gitlab.com/gitlab-org/gitlab-ce/issues/14103

Release notes

Merge requests which apply changes to multiple files will sometimes collapse large file diffs in order to improve performance. When this happens, it's easy to overlook a file and not review it, especially in merge requests with many files.

GitLab will highlight diffs containing collapsed files so they are not missed during a review.

Edited by Pedro Moreira da Silva