Skip to content

Feature flag: pull_mirror_branch_prefix - rollout or delete?

This issue is to discuss the future of the pull_mirror_branch_prefix feature.

It was introduced by teamDelivery with !17368 (merged) as part of the effort to move security development from dev to GitLab.com mirrors.

The feature itself is in the groupsource code area, and the Delivery team ended up not using it.

What does the feature do?

Enabling the FF allows specifying a branch prefix on pull mirroring, it will be useful on forked project to keep track of upstream branches on a dedicated branch namespace.

graph LR
  subgraph Canonical
    c-master(master)
    c-stable(12-3-stable)
    c-auto-deploy(12-3-auto-deploy-20190911)
    c-feature(feature/some-new-feature)
    c-bug(15015-some-bug-fix)
  end

  subgraph Security
    s-master(security/master)
    s-stable(security/12-3-stable)
    s-auto-deploy(security/12-3-auto-deploy-20190911)
  end

  c-master -.->|pull mirror| s-master
  c-stable -.->|pull mirror| s-stable
  c-auto-deploy -.->|pull mirror| s-auto-deploy

Status of the feature flag

At the time of writing this FF is enabled on staging but only in use on 3 delivery owned test projects:

  • delivery-team-tests/prefixed-mirrors/gitaly
  • rspeicher/gitlab
  • gitlab-org/security/gitlab-foss

On production, it is enabled only on a specific project that no longer exists today.

Decision to be made

Should we rollout this feature flag or remove the feature?