Align Team add_X methods with add_user
Summary
The #add_X
methods such as #add_developer
are just a friendly shortcut to calling #add_user
with the specified role. However, #add_user
params have moved beyond what the #add_X
methods pass through.
We should just bundle the params and pass them through to indicate the true intent of the method, update the params available to #add_X
, and future proof for changes to #add_user
.
Improvements
Update to available #add_user
params, and future proof.
Risks
Involved components
- app/models/project_team.rb
- app/models/group.rb