[cached_markdown_blob] Enable caching of markdown when viewing blob
What
Enable the cached_markdown_blob
feature flag by default added in #262045 (closed).
Owners
- Team: groupsource code
- Most appropriate slack channel to reach out to:
#g_create_source-code-be
- Best individual to reach out to: @patrickbajao
Expectations
What are we expecting to happen?
Improve response time of Projects::BlobController#show.json
endpoint when viewing https://gitlab.com/gitlab-org/gitlab/-/blob/master/CHANGELOG.md.
What might happen if this goes wrong?
- File doesn't render properly.
- Cache usage is way up.
What can we monitor to detect problems with this?
-
Memory Used graph to see if there are drastic memory increaseNot really useful since it's an LRU cache - Hit ratio graph to see if there's dramatic change (lower than usual) which could mean that we are evicting more useful keys.
- https://dashboards.gitlab.net/d/redis-cache-main/redis-cache-overview?orgId=1
- Projects::BlobController#show grafana metrics
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project
Roll Out Steps
-
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true
) -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set feature_name true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled
Edited by Patrick Bajao