Follow-up from "Fix problem with Groups API search argument"
The following discussion from !46394 (merged) should be addressed:
-
@mparuszewski started a discussion: I've noticed strange behaviour and difference in usage of
FactoryBot.build
andFactoryBot.create
methods:build_namespace = FactoryBot.build(:namespace, name: 'GitLab', path: 'gitlab-org') => #<Namespace:0x00007fd2b79bf758 id: nil, name: "gitlab-org", path: "gitlab-org", ... >
created_namespace = FactoryBot.create(:namespace, name: 'GitLab', path: 'gitlab-org') => #<Namespace:0x00007fd2b79bf758 id: nil, name: "John Doe2", path: "gitlab-org", ... >
Looks like for some reason when creating namespace the factory ignores value provided in the params and takes value from the sequence, what is strange -> it does not take that value from the sequence defined in
Namespace
factory but from https://gitlab.com/gitlab-org/gitlab/blob/ab97b007457f0b4abb0eccf2abea052c8e4c57bf/spec/factories/sequences.rb#L5 instead. I believe we can resolve this problem in follow-up issue. WDYT?
Implementation plan
-
backend check factories for Namespace/Group/Project
andname
generator to see what is causing the situation where the name is not overridden by provided value, but is using value generated by factory generator,
Edited by Alan (Maciej) Paruszewski