Fix various issues with vulnerability list when there are no vulnerabilities
There are several bugs when the security dashboard/vulnerability list has no vulnerabilities at all (meaning there are zero vulnerabilities even with the filters removed):
1. When viewing the project-level security dashboard, an error message will be incorrectly shown:
This is because in projects_helper.rb
: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/helpers/ee/projects_helper.rb#L210-215
if there are no vulnerabilities, projectFullPath
is not provided, which causes the GraphQL queries to bomb because it doesn't pass in the required projectFullPath
variable:
2. If filters are selected, the "your filter produced no results" message is prioritized over the "there are no vulnerabilities" message:
This should be reversed because the "no filter results" message makes it seem like there are results but are filtered out, when there are actually no vulnerabilities to begin with.
3. The "your filter produced no results" message is missing the SVG image:
What it shows | What it should show |
---|---|
Edited by Daniel Tian