Polling continues after job is finished
Summary
We continue to poll on the job detail page even after the job is finished. The data we are fetching looks to just be the finished jobs data (which I'm unsure why we still need to poll for this). This leads to un-needed calls to our server.
Steps to reproduce
- Visit a finished jobs detail page
- Check the network tab for continued calls
Possible fixes
Stop polling the server for data once the job is finished.
This should be very similar to my work in !47301 (merged) except GraphQL is not involved and we are using our homegrown polling solution here.
The solution could be adding a watcher in app/assets/javascripts/jobs/components/job_app.vue
. We could check the job status and if the status is one of our finished statuses we then should stop polling.
Looks like we have two functions we should take a look at. stopPollingTrace
and stopPolling
.
Note
We should ensure if a job is restarted that polling is kicked back on.