Add type annotations to resolvers
Why are we doing this work
A new Rubocop rule has been added: GraphQL/ResolverType
(see !47375 (merged))
This rule requires that all resolvers have a top-level type
DSL method that annotates the resolver with its return type.
There are currently 25 known exclusions. The purpose of this issue is to co-ordinate the work off adding types to all these files.
List of current exclusions:
I have added a list of all users I have seen to have edited the files in question - If your name is mentioned, and the file associated with your name is not yet checked off, please consider claiming it:
- Check the box next to the filename to claim it.
- Add the appropriate
type
to the resolver file. - Edit this description to link to the MR you have created.
Please see the list below for sets of candidates and links to MRs:
-
app/graphql/resolvers/assigned_merge_requests_resolver.rb: !47547 (merged) - @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/authored_merge_requests_resolver.rb: !47547 (merged) - @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/ci/pipeline_stages_resolver.rb: - @lauraMon (Laura Montemayor)
-
app/graphql/resolvers/commit_pipelines_resolver.rb: !47634 (merged) - @iamphill (Phil Hughes)
-
app/graphql/resolvers/error_tracking/sentry_error_stack_trace_resolver.rb: !47647 (merged) - @seanarnold (Sean Arnold)
- @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/group_issues_resolver.rb: !47647 (merged) - @mdelaossa (Mario de la Ossa)
- @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/group_merge_requests_resolver.rb: !47647 (merged) - @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/group_milestones_resolver.rb: !47647 (merged) - @engwan (Heinrich Lee Yu)
-
app/graphql/resolvers/members_resolver.rb: 47647 - @cablett (charlie ablett)
-
app/graphql/resolvers/merge_request_pipelines_resolver.rb: !47634 (merged) - @iamphill (Phil Hughes)
- @reprazent (Bob Van Landuyt)
-
app/graphql/resolvers/merge_request_resolver.rb: !47647 (merged) - @reprazent (Bob Van Landuyt)
- @yorickpeterse (Yorick Peterse)
- @stanhu (Stan Hu)
- @godfat-gitlab (Lin Jen-Shin)
- @DouweM (Douwe Maan)
- @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/merge_requests_resolver.rb: see !47538 (closed) - @godfat-gitlab (Lin Jen-Shin)
- @alexkalderimis (Alex Kalderimis)
- @egrieff (Eugenia Grieff)
- @ahegyi (Adam Hegyi)
- @jarka (Jarka Košanová)
- @djensen (Dan Jensen)
- @digitalmoksha (Brett Walker)
- @reprazent (Bob Van Landuyt)
-
app/graphql/resolvers/project_merge_requests_resolver.rb: !47647 (merged) - @alexkalderimis (Alex Kalderimis)
- @ahegyi (Adam Hegyi)
-
app/graphql/resolvers/project_milestones_resolver.rb: !47647 (merged) - @engwan (Heinrich Lee Yu)
-
app/graphql/resolvers/project_pipelines_resolver.rb: !47634 (comment 447214283) (thanks @iamphill) - @lauraMon (Laura Montemayor)
- @reprazent (Bob Van Landuyt)
- @avielle (Avielle Wolfe)
-
app/graphql/resolvers/projects/snippets_resolver.rb: !47548 (merged) - @vij (Vijay Hawoldar)
- @fjsanpedro (Francisco Javier López)
-
app/graphql/resolvers/snippets_resolver.rb: !47548 (merged) - @fjsanpedro (Francisco Javier López)
- @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/user_merge_requests_resolver.rb: !47547 (merged) - @alexkalderimis (Alex Kalderimis)
-
app/graphql/resolvers/users/group_count_resolver.rb: - @asubramanian1 (Aishwarya Subramanian)
-
app/graphql/resolvers/users/snippets_resolver.rb: !47548 (merged) - @fjsanpedro (Francisco Javier López)
-
ee/app/graphql/resolvers/ci/jobs_resolver.rb: - @avielle (Avielle Wolfe)
-
ee/app/graphql/resolvers/geo/merge_request_diff_registries_resolver.rb: - @alexives (Alex Ives) - !47584 (merged)
-
ee/app/graphql/resolvers/geo/package_file_registries_resolver.rb: - @alexives (Alex Ives) - !47584 (merged)
-
ee/app/graphql/resolvers/geo/terraform_state_version_registries_resolver.rb: - @alexives (Alex Ives) - !47584 (merged)
-
ee/app/graphql/resolvers/vulnerabilities_base_resolver.rb: - @avielle (Avielle Wolfe)