Skip to content

Multiple E2E failures for changing application settings via API

Summary

Several tests that involve setting application settings via API:

  • qa/specs/features/browser_ui/1_manage/login/register_spec.rb
  • qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb
  • qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb

Seen on master - https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/875841343 & https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/875841345 and Staging - https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/2447918

Stack trace

register_spec:

Failures:
  1) Manage standard when admin approval is not required behaves like registration and login allows the user to registers and login
     Failure/Error: Runtime::ApplicationSettings.set_application_settings(require_admin_approval_after_user_signup: enable_or_disable)
     
     RuntimeError:
       Couldn't set application settings {:require_admin_approval_after_user_signup=>false}
     Shared Example Group: "registration and login" called from ./qa/specs/features/browser_ui/1_manage/login/register_spec.rb:47
     # ./qa/runtime/application_settings.rb:21:in `set_application_settings'
     # ./qa/specs/features/browser_ui/1_manage/login/register_spec.rb:152:in `set_require_admin_approval_after_user_signup_via_api'
     # ./qa/specs/features/browser_ui/1_manage/login/register_spec.rb:44:in `block (4 levels) in <module:QA>'

default_branch_name_setting_spec:

  4) Create Default branch name instance setting sets the default branch name for a new project
     Failure/Error: Runtime::ApplicationSettings.set_application_settings(default_branch_name: 'main')
     
     RuntimeError:
       Couldn't set application settings {:default_branch_name=>"main"}
     # ./qa/runtime/application_settings.rb:21:in `set_application_settings'
     # ./qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb:9:in `block (3 levels) in <module:QA>'

push_over_http_file_size_spec

2) Create push after setting the file size limit via admin/application_settings push fails when the file size is above the limit
     Failure/Error: expect(response.code).to eq(200)
     
       expected: 200
            got: 400
     
       (compared using ==)
     # ./qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb:52:in `set_file_size_limit'
     # ./qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb:40:in `block (3 levels) in <module:QA>'

Screenshot / HTML page

Possible fixes

Potentially result of a recent change in that part of the API (last 24h), it is hard to pinpoint the time correctly as master pipelines were not running tests for some time due to an issue with package-and-qa.