Follow-up from "Added DAST path to display on vulnerabilities list"
In #243569 (closed) we added the omitted DAST path to the security dashboard. There were a few callouts in the review that would simplify the code and bring us further to a standard approach for data types.
The following discussions from !49616 (merged) should be addressed:
-
@markrian started a discussion: thought: We'll need to be careful here in future, if, say, Dependency Scanning, SAST or Secret Scanning end up adding a
path
to theirlocation
field as well, since in that case the path will be shown instead of the file. Still, that'd be a minor bug we may never have to deal with🙂 -
@markrian started a discussion: thought: I feel like this is somewhat duplicating the logic/dependencies of the
createLocationString
, and that this should instead be something like:return Boolean(this.locationString);
and the
createLocationString
method should be turned into alocationString
computed prop.
Implementation Plan
-
Update ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_list.vue
-
Give file
path preference thanpath
-
Move Boolean(item.location.image || item.location.file || item.location.path);
to usecreateLocationString
instead
-
-
Update specs